ThomasMarquardt commented on a change in pull request #1842: HADOOP-16730 : ABFS: Add Authorizer Interface URL: https://github.com/apache/hadoop/pull/1842#discussion_r384049325
########## File path: hadoop-tools/hadoop-azure/src/site/markdown/abfs.md ########## @@ -626,7 +626,7 @@ points for third-parties to integrate their authentication and authorization services into the ABFS client. * `CustomDelegationTokenManager` : adds ability to issue Hadoop Delegation Tokens. -* `AbfsAuthorizer` permits client-side authorization of file operations. +* `SASTokenProvider` permits client-side authorization of file operations. Review comment: Client-side makes it sound like the client authorizes itself, which is not the case. I suggest " `SASTokenProvider` allows for custom provision of Azure Storage Shared Access Signature (SAS) tokens." to keep with the pattern on line 630. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
