bilaharith commented on a change in pull request #1948: HADOOP-16855. wildfly
classpath/loading issues
URL: https://github.com/apache/hadoop/pull/1948#discussion_r407653128
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory.java
##########
@@ -149,11 +149,11 @@ private void initializeSSLContext(SSLChannelMode
preferredChannelMode)
throws NoSuchAlgorithmException, KeyManagementException {
switch (preferredChannelMode) {
case Default:
- if (!openSSLProviderRegistered) {
- OpenSSLProvider.register();
- openSSLProviderRegistered = true;
- }
try {
+ if (!openSSLProviderRegistered) {
Review comment:
Wouldn't it be better to move the code within try-catch into a new method so
that the same can be resued for the case openSSL as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
