steveloughran commented on a change in pull request #1948: HADOOP-16855.
wildfly classpath/loading issues
URL: https://github.com/apache/hadoop/pull/1948#discussion_r408003485
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory.java
##########
@@ -149,11 +149,11 @@ private void initializeSSLContext(SSLChannelMode
preferredChannelMode)
throws NoSuchAlgorithmException, KeyManagementException {
switch (preferredChannelMode) {
case Default:
- if (!openSSLProviderRegistered) {
- OpenSSLProvider.register();
- openSSLProviderRegistered = true;
- }
try {
+ if (!openSSLProviderRegistered) {
Review comment:
I'd put it here so that if someone asked for openSSL and there were
problems, it really would fail. It was in default where wildfly load (and
pointer errors) triggered catch and downgrade.
For the S3A Binding there already was some classpath catching, so I Added it
there too so that any failure here just falls back to the default AWS SDK
binding. For abfs I've left it alone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
