snvijaya commented on a change in pull request #1969:
URL: https://github.com/apache/hadoop/pull/1969#discussion_r412108329
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java
##########
@@ -27,6 +27,15 @@
@InterfaceAudience.Public
@InterfaceStability.Evolving
public final class ConfigurationKeys {
+
+ /**
+ * Each time a FS instance is created a Getacl call is made. If the call
+ * fails with 400 Bad request, the account is determined to be a non-HNS
+ * account.
+ * If this config is present, use that to determine account HNS status. If
+ * config is not present, default behaviour will be calling getAcl.
Review comment:
Minor. Change comment to :
/**
* Config to specify if the configured account is HNS enabled or not. If
this config is not set,
* getacl call is made on account filesystem root path to determine HNS
status.
*/
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -253,6 +259,20 @@ public boolean getIsNamespaceEnabled() throws
AzureBlobFileSystemException {
return isNamespaceEnabled;
}
+ @VisibleForTesting
+ boolean isNameSpaceEnabledSetFromConfig() {
Review comment:
This method should be in AbfsConfiguration.java ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
