bilaharith commented on a change in pull request #1969:
URL: https://github.com/apache/hadoop/pull/1969#discussion_r412131351



##########
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -253,6 +259,20 @@ public boolean getIsNamespaceEnabled() throws 
AzureBlobFileSystemException {
     return isNamespaceEnabled;
   }
 
+  @VisibleForTesting
+  boolean isNameSpaceEnabledSetFromConfig() {

Review comment:
       No.
   Though the possible values for the config is true/false, we cannot have a 
default value for the same. So we accept the config value as String and if it 
is valid(true/false) we set it to the 
AzureBlobFileSystemStore.isNamespaceEnabled.
   
   If the config is not present or the value specified is invalid, this method 
returns false, indicating it could not set the 
AzureBlobFileSystemStore.isNamespaceEnabled field.
   
   And according to the return value of this method, the caller method returns 
AzureBlobFileSystemStore.isNamespaceEnabled field or falls back to the default 
behaviour.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to