mukund-thakur commented on a change in pull request #1944:
URL: https://github.com/apache/hadoop/pull/1944#discussion_r415618656
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java
##########
@@ -400,18 +406,22 @@ public UploadPartRequest newUploadPartRequest(
int size,
InputStream uploadStream,
File sourceFile,
- Long offset) {
+ Long offset) throws PathIOException {
checkNotNull(uploadId);
// exactly one source must be set; xor verifies this
checkArgument((uploadStream != null) ^ (sourceFile != null),
"Data source");
checkArgument(size >= 0, "Invalid partition size %s", size);
- checkArgument(partNumber > 0 && partNumber <= 10000,
- "partNumber must be between 1 and 10000 inclusive, but is %s",
- partNumber);
+ checkArgument(partNumber > 0,
+ "partNumber must be between 1 and %s inclusive, but is %s",
+ UPLOAD_PART_COUNT_LIMIT, partNumber);
LOG.debug("Creating part upload request for {} #{} size {}",
uploadId, partNumber, size);
+ if (partNumber >= InternalConstants.UPLOAD_PART_COUNT_LIMIT) {
Review comment:
Greater than??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
