mukund-thakur commented on a change in pull request #1944:
URL: https://github.com/apache/hadoop/pull/1944#discussion_r416427061
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java
##########
@@ -394,6 +395,13 @@ public void close() throws IOException {
}
LOG.debug("Upload complete to {} by {}", key, writeOperationHelper);
} catch (IOException ioe) {
+ // the operation failed.
+ // if this happened during a multipart upload, abort the
+ // operation, so as to not leave (billable) data
+ // pending on the bucket
+ if (multiPartUpload != null) {
+ multiPartUpload.abort();
Review comment:
I feel this abort call should already have been present? Does this mean
we had a bug of having the partial data in S3 in case of other exceptions as
well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
