iwasakims commented on a change in pull request #1950:
URL: https://github.com/apache/hadoop/pull/1950#discussion_r416331324
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestPartialRenamesDeletes.java
##########
@@ -54,7 +54,12 @@
import static org.apache.hadoop.fs.contract.ContractTestUtils.*;
import static org.apache.hadoop.fs.s3a.Constants.*;
import static org.apache.hadoop.fs.s3a.S3ATestUtils.MetricDiff;
-import static org.apache.hadoop.fs.s3a.S3ATestUtils.*;
+import static org.apache.hadoop.fs.s3a.S3ATestUtils.assume;
Review comment:
I got issue on getting test bucket name even if `test.fs.s3a.name` was
defined in the test conf and othter itests worked.
```
java.lang.NullPointerException: No test bucket
at
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:895)
at
org.apache.hadoop.fs.s3a.S3ATestUtils.getTestBucketName(S3ATestUtils.java:739)
at
org.apache.hadoop.fs.s3a.impl.ITestPartialRenamesDeletes.createConfiguration(ITestPartialRenamesDeletes.java:326)
```
I suspected the configuration reloading in S3ATestUtils as the cause. The
change is leftover of trial-and-error. Since I can not reproduce the issue now,
I will revert this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
