iwasakims commented on a change in pull request #1950:
URL: https://github.com/apache/hadoop/pull/1950#discussion_r416346311
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardToolLocal.java
##########
@@ -165,18 +165,19 @@ public void testImportNoFilesystem() throws Throwable {
@Test
public void testInfoBucketAndRegionNoFS() throws Throwable {
- intercept(FileNotFoundException.class,
+ intercept(UnknownStoreException.class,
() -> run(BucketInfo.NAME, "-meta",
LOCAL_METADATA, "-region",
"any-region", S3A_THIS_BUCKET_DOES_NOT_EXIST));
}
@Test
public void testInitNegativeRead() throws Throwable {
- runToFailure(INVALID_ARGUMENT,
- Init.NAME, "-meta", LOCAL_METADATA, "-region",
- "eu-west-1",
- READ_FLAG, "-10");
+ intercept(CommandFormat.UnknownOptionException.class,
Review comment:
I agree to remove the test. The error caused by treating `-10` as option
rather than option's value since it `startsWith("-")`. The read flag does not
need to handle negative value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
