mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052492
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##########
@@ -133,59 +159,48 @@ public void testDeleteStatistics() throws IOException {
+ "in Abfs");
AzureBlobFileSystem fs = getFileSystem();
/*
- This directory path needs to be root for triggering the
- directories_deleted counter.
+ This directory path needs to be root for triggering the
+ directories_deleted counter.
*/
Path createDirectoryPath = path("/");
Path createFilePath = path(getMethodName());
- Map<String, Long> metricMap = fs.getInstrumentation().toMap();
- //Test for initial statistic values before deleting any directory or files
Review comment:
Initial stats should be asserted to have values zero. I asked to move in
a separate method and reuse in all tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
