mukund-thakur commented on a change in pull request #1991:
URL: https://github.com/apache/hadoop/pull/1991#discussion_r427052835
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##########
@@ -249,32 +252,44 @@ public void testOpenAppendRenameExists() throws
IOException {
metricMap = fs.getInstrumentation().toMap();
//Testing large number of method calls to open, append.
- assertEquals("Mismatch in op_open", NUMBER_OF_OPS,
- (long) metricMap.get("op_open"));
- assertEquals("Mismatch in op_append", NUMBER_OF_OPS,
- (long) metricMap.get("op_append"));
+ assertEquals("Mismatch in " + openOp, NUMBER_OF_OPS,
+ (long) metricMap.get(openOp));
+ assertEquals("Mismatch in " + appendOp, NUMBER_OF_OPS,
+ (long) metricMap.get(appendOp));
for (int i = 0; i < NUMBER_OF_OPS; i++) {
// rename and then back to earlier name for no error while looping.
fs.rename(destCreateFilePath, createFilePath);
fs.rename(createFilePath, destCreateFilePath);
//check if first name is existing and 2nd is not existing.
- assertTrue("Mismatch in file Path existing",
+ assertTrue("File should exist",
Review comment:
put filename in the message.
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##########
@@ -249,32 +252,44 @@ public void testOpenAppendRenameExists() throws
IOException {
metricMap = fs.getInstrumentation().toMap();
//Testing large number of method calls to open, append.
- assertEquals("Mismatch in op_open", NUMBER_OF_OPS,
- (long) metricMap.get("op_open"));
- assertEquals("Mismatch in op_append", NUMBER_OF_OPS,
- (long) metricMap.get("op_append"));
+ assertEquals("Mismatch in " + openOp, NUMBER_OF_OPS,
+ (long) metricMap.get(openOp));
+ assertEquals("Mismatch in " + appendOp, NUMBER_OF_OPS,
+ (long) metricMap.get(appendOp));
for (int i = 0; i < NUMBER_OF_OPS; i++) {
// rename and then back to earlier name for no error while looping.
fs.rename(destCreateFilePath, createFilePath);
fs.rename(createFilePath, destCreateFilePath);
//check if first name is existing and 2nd is not existing.
- assertTrue("Mismatch in file Path existing",
+ assertTrue("File should exist",
fs.exists(destCreateFilePath));
- assertFalse("Mismatch in file Path existing",
+ assertFalse("File should not exist",
Review comment:
put filename in the message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
