ayushtkn commented on pull request #2058:
URL: https://github.com/apache/hadoop/pull/2058#issuecomment-639986361


   Thanx @umamaheswararao for the work here. 
   * The TestCommonConfigurationFields is related, It expects the 
configurations to be added in CommonConfigurationKeys.java as well
   
   * Apart from this, The HDFS tests didn't run and I feel couple of them, 
testing invalid scheme may fail now like these are failing now :
   
   
TestViewFileSystemOverloadSchemeWithHdfsScheme#testInvalidOverloadSchemeTargetFS
   
TestViewFSOverloadSchemeWithMountTableConfigInHDFS#testInvalidOverloadSchemeTargetFS
   
   * There are couple of places, where these configurations were explicitly 
defined, mostly I guess in tests, You may remove couple of them now, which ever 
places you remember 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to