ayushtkn commented on a change in pull request #2058:
URL: https://github.com/apache/hadoop/pull/2058#discussion_r436244931
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
##########
@@ -124,6 +124,24 @@ public void initializeMemberVariables() {
xmlPrefixToSkipCompare.add("fs.adl.");
xmlPropsToSkipCompare.add("fs.AbstractFileSystem.adl.impl");
+ // ViewfsOverloadScheme target fs impl property keys are dynamically
+ // constructed and they are advanced props.
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.abfs.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.abfss.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.file.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.ftp.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.hdfs.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.http.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.https.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.o3fs.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.oss.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.s3a.impl");
+ xmlPropsToSkipCompare.
+ add("fs.viewfs.overload.scheme.target.swebhdfs.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.webhdfs.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.wasb.impl");
+ xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.swift.impl");
+
Review comment:
Can we just add one line instead :
` xmlPrefixToSkipCompare.add("fs.viewfs.overload.scheme.target.");`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
