saintstack commented on a change in pull request #2065:
URL: https://github.com/apache/hadoop/pull/2065#discussion_r438319331
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
##########
@@ -1945,6 +1945,18 @@
<description>The HistoryStorage class to use to cache history
data.</description>
</property>
+<property>
+ <name>mapreduce.jobhistory.minicluster.enabled</name>
+ <value>true</value>
+ <description>Whether to launch jobhistory server inminicluster.</description>
+</property>
+
+<property>
+ <name>mapreduce.jobhistory.minicluster.launch.timeout.ms</name>
+ <value>60000</value>
+ <description>Timeout to launch jobhistory server inminicluster.</description>
+</property>
+
Review comment:
These are test-time configs. Is it common practice adding them to the
default xml? Just wondering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
