ndimiduk commented on a change in pull request #2065:
URL: https://github.com/apache/hadoop/pull/2065#discussion_r442401950
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRBringup.java
##########
@@ -36,5 +40,21 @@ public void testBringUp() throws IOException {
if (mr != null) { mr.shutdown(); }
}
}
-
+
+ @Test
+ public void testMiniMRYarnClusterWithoutJHS() throws IOException {
+ MiniMRYarnCluster mr = null;
+ try {
+ final Configuration conf = new Configuration();
+ conf.setBoolean(MiniMRYarnCluster.MR_HISTORY_MINICLUSTER_ENABLED, false);
+ mr = new MiniMRYarnCluster("testMiniMRYarnClusterWithoutJHS");
+ mr.init(conf);
+ Assert.assertEquals(null, mr.getHistoryServer());
Review comment:
should this assert happen after the call to `start()`?
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
##########
@@ -259,7 +267,10 @@ public void run() {
};
}.start();
Review comment:
Yes, preserving the default value makes sense. I'm just wondering if the
resource allocation can be skipped entirely when the `jhs` is disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
