xiaoyuyao commented on a change in pull request #2085:
URL: https://github.com/apache/hadoop/pull/2085#discussion_r445127216
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java
##########
@@ -345,28 +373,28 @@ public long read() {
* implementation, otherwise is arranges for the cache to be updated later
*/
@Override
- public ListenableFuture<List<String>> reload(final String key,
- List<String> oldValue)
+ public ListenableFuture<Set<String>> reload(final String key,
+ Set<String> oldValue)
throws Exception {
LOG.debug("GroupCacheLoader - reload (async).");
if (!reloadGroupsInBackground) {
return super.reload(key, oldValue);
}
backgroundRefreshQueued.incrementAndGet();
- ListenableFuture<List<String>> listenableFuture =
- executorService.submit(new Callable<List<String>>() {
+ ListenableFuture<Set<String>> listenableFuture =
+ executorService.submit(new Callable<Set<String>>() {
Review comment:
Good catch. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
