jojochuang commented on a change in pull request #2085:
URL: https://github.com/apache/hadoop/pull/2085#discussion_r446311389
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java
##########
@@ -203,17 +202,47 @@ private IOException noGroupsForUser(String user) {
/**
* Get the group memberships of a given user.
* If the user's group is not cached, this method may block.
+ * Note this method can be expensive as it involves Set->List conversion.
+ * For user with large group membership (i.e., > 1000 groups), we recommend
+ * using getGroupSet to avoid the conversion and fast membership look up via
+ * contains().
Review comment:
Would it make sense to deprecate this API to push users to use the new
API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
