mehakmeet commented on a change in pull request #2141:
URL: https://github.com/apache/hadoop/pull/2141#discussion_r455120444
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/SimpleKeyProvider.java
##########
@@ -49,6 +51,27 @@ public String getStorageAccountKey(String accountName,
Configuration rawConfig)
LOG.warn("Unable to get key from credential providers. {}", ioe);
}
+ // Validating the key.
+ try {
+ validateStorageAccountKey(key);
+ } catch (InvalidConfigurationValueException e) {
+ e.printStackTrace();
Review comment:
I tried to place at L48 as well in the beginning but a test was getting
broken, I found at that it expects a certain exception, it passes a null key,
which makes the validate() method throw a different error. I think by adding a
condition in the catch to throw that particular error if the key is null might
solve this. So, I'll be changing it in the next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
