steveloughran commented on a change in pull request #2141:
URL: https://github.com/apache/hadoop/pull/2141#discussion_r455180197
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/SimpleKeyProvider.java
##########
@@ -49,6 +51,27 @@ public String getStorageAccountKey(String accountName,
Configuration rawConfig)
LOG.warn("Unable to get key from credential providers. {}", ioe);
}
+ // Validating the key.
+ try {
+ validateStorageAccountKey(key);
+ } catch (InvalidConfigurationValueException e) {
+ e.printStackTrace();
Review comment:
don't worry about breaking the test, we've moved the vaildation and
should expect it. Instead the test will need to handle the way invalid
configurations are raised.
Or go with mukund -just make sure that the wrapping exception uses the
message of the caught exception and adds it as the cause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
