bshashikant commented on a change in pull request #2165:
URL: https://github.com/apache/hadoop/pull/2165#discussion_r460737232
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
##########
@@ -1284,6 +1288,7 @@ void startCommonServices(Configuration conf, HAContext
haContext) throws IOExcep
dir.setINodeAttributeProvider(inodeAttributeProvider);
}
snapshotManager.registerMXBean();
+ snapshotDeletionGc.schedule();
Review comment:
I think its better to start the gc work in
FSNameSystem#startActiveServices() after quota setup and initialization is done
startActiveServices()
``
// Initialize the quota.
dir.updateCountForQuota();
// Enable quota checks.
dir.enableQuotaChecks();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
