bshashikant commented on a change in pull request #2165:
URL: https://github.com/apache/hadoop/pull/2165#discussion_r462750158
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
##########
@@ -7166,6 +7178,30 @@ void deleteSnapshot(String snapshotRoot, String
snapshotName,
logAuditEvent(true, operationName, rootPath, null, null);
}
+ public void gcDeletedSnapshot(String snapshotRoot, String snapshotName)
+ throws IOException {
+ final String operationName = "gcDeletedSnapshot";
+ String rootPath = null;
+ final INode.BlocksMapUpdateInfo blocksToBeDeleted;
+
+ checkOperation(OperationCategory.WRITE);
+ writeLock();
+ try {
+ checkOperation(OperationCategory.WRITE);
+ rootPath = Snapshot.getSnapshotPath(snapshotRoot, snapshotName);
+ checkNameNodeSafeMode("Cannot gcDeletedSnapshot for " + rootPath);
+
+ final long now = Time.now();
+ final INodesInPath iip = dir.resolvePath(null, snapshotRoot,
DirOp.WRITE);
+ snapshotManager.assertMarkedAsDeleted(iip, snapshotName);
+ blocksToBeDeleted = FSDirSnapshotOp.deleteSnapshot(
+ dir, snapshotManager, iip, snapshotName, now);
+ } finally {
+ writeUnlock(operationName, getLockReportInfoSupplier(rootPath));
+ }
+ removeBlocks(blocksToBeDeleted);
Review comment:
do we need to do a null check here before calling removeBlocks as its
done in other code paths where remove blocks is getting called ?
e.g. FsNamesystem#deleteSnapshot:
---------`
// Breaking the pattern as removing blocks have to happen outside of the
// global lock
if (blocksToBeDeleted != null) {
removeBlocks(blocksToBeDeleted);
}
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
