bshashikant commented on a change in pull request #2176:
URL: https://github.com/apache/hadoop/pull/2176#discussion_r466152617
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
##########
@@ -244,6 +244,10 @@
"dfs.namenode.snapshot.capture.openfiles";
boolean DFS_NAMENODE_SNAPSHOT_CAPTURE_OPENFILES_DEFAULT = false;
+ String DFS_NAMENODE_SNAPSHOT_TRASHROOT_ENABLED =
+ "dfs.namenode.snapshot.trashroot.enabled";
+ boolean DFS_NAMENODE_SNAPSHOT_TRASHROOT_ENABLED_DEFAULT = false;
+
String DFS_PROVIDED_ALIASMAP_INMEMORY_RPC_ADDRESS =
Review comment:
If we hide it, i would prefer to not add it in hdfs-default.xml as well.
We can make this an internal config which is required only if u want to
restrict renames out of snapshottable root which can be turned on only if a
requirement like this arises in certain use cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
