bshashikant commented on a change in pull request #2176:
URL: https://github.com/apache/hadoop/pull/2176#discussion_r466525092
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
##########
@@ -516,6 +516,11 @@
public static final int
DFS_NAMENODE_SNAPSHOT_SKIPLIST_MAX_SKIP_LEVELS_DEFAULT = 0;
+ public static final String DFS_NAMENODE_SNAPSHOT_TRASHROOT_ENABLED =
+ "dfs.namenode.snapshot.trashroot.enabled";
+ public static final boolean DFS_NAMENODE_SNAPSHOT_TRASHROOT_ENABLED_DEFAULT =
Review comment:
i guess we need to define these configs in SnapshotManager if we intend
not add it in hdfs-default.xml(which i would prefer). It leads to test failure
here "hadoop.tools.TestHdfsConfigFields"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
