bshashikant commented on pull request #2212: URL: https://github.com/apache/hadoop/pull/2212#issuecomment-671774640
Thanks @vivekratnavel for putting up the patch. The patch in general looks good. Some comments inline: 1) Since the patch modifies SnapshotInfo class, let's remove SnapshotStatus.Bean() 2) Having different column for snapshotName and then snapshot path may not be useful. Instead can we just have one column for the snapshot path (snapshotName is implicit). 3) Snapshot permission, owner and group added newly to the UI page .. Any specific reason? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
