vivekratnavel commented on pull request #2212:
URL: https://github.com/apache/hadoop/pull/2212#issuecomment-672275779


   @bshashikant @bharatviswa504 Thanks for the reviews!
   
   > Since the patch modifies SnapshotInfo class, let's remove 
SnapshotStatus.Bean()
   
   Done
   
   > Having different column for snapshotName and then snapshot path may not be 
useful. Instead can we just have one column for the snapshot path (snapshotName 
is implicit).
   
   Done
   
   > Snapshot permission, owner and group added newly to the UI page .. Any 
specific reason?
   
   I added these new columns to be consistent with the display of snapshottable 
directories table and to provide more useful information about snapshots to the 
user. 
   
   Please take another look at the updated patch. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to