liuml07 commented on pull request #2197: URL: https://github.com/apache/hadoop/pull/2197#issuecomment-674491150
The patch looks good to me overall. A question is: should we rename the word "force" with "ignoreTimeElapsed" to make it clear. If agreed on it includes updating the parameters name and Javadoc. Thoughts? @sguggilam I will give a final review next week. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
