liuml07 edited a comment on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-680714535
@sguggilam When I backport the code, I went through the code again. I think
I found one bug. Before I revert the change, I want to confirm with you. The
existing calls of `reloginFromKeytab(false)` or `reloginFromKeytab(true)`, the
parameter value `false` or `true` was previously for `checkTGT`. But with this
change, they are for `ignoreTimeElapsed`. So the code calling the previously
private method is broken - I found two places.
So, first we can change the new public API from
```
public void reloginFromKeytab(boolean ignoreTimeElapsed) throws
IOException {
reloginFromKeytab(false, ignoreTimeElapsed);
}
```
to something like:
```
public void reloginFromKeytab(boolean checkTGT) throws IOException {
reloginFromKeytab(checkTGT, true);
}
```
Second, we should replace existing calls `reloginFromKeytab(false)` or
`reloginFromKeytab(true)` in UGI to `reloginFromKeytab(false, false)` or
`reloginFromKeytab(true, false)`.
Could you explain more? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
