liuml07 edited a comment on pull request #2197:
URL: https://github.com/apache/hadoop/pull/2197#issuecomment-681017115
@sguggilam
1. We both agree on that we need to change both two callsites in UGI.
2. For the new API, if we keep it as it, is a bit confusing when user calls
with `false` value when user does not need to ignore last login time. In that
case, we still ignore the TGT check since the first parameter is always `false`.
```
public void reloginFromKeytab(boolean ignoreTimeElapsed) throws
IOException {
reloginFromKeytab(false, ignoreTimeElapsed);
}
```
Since the forceful login is the main target, how about we create a new
method name, and use `false` for both parameter?
```
public void forceReloginFromKeytab() throws IOException {
reloginFromKeytab(false, true);
}
```
3. I think since this a bug, it's better not to create followup JIRAs but
instead create a new full pull request. So when people backport or check the
change for debugging, they do not need to jump different PRs to understand
what's happening as addendum. I will revert the commit in git repo, and the new
PR will be including the full code. How about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
