wayneseguin commented on pull request #2248: URL: https://github.com/apache/hadoop/pull/2248#issuecomment-681163854
The JIRA is https://issues.apache.org/jira/browse/HADOOP-172304. Is there a specific place I should link it? As to your questions and comments, while I agree with the potential performance improvement, do we want to force users to reconfigure their systems in a manner possibly incompatible with other requirements they might have? And if so, then that should be part of the published installation instructions, I don't think that is the right thing for the users, however. The quotes around the %JAVA_HOME% don't help; that line actually works either way. There is an alternate solution where proper quoting in 2 different places can bypass the issue. One in hadoop-config.cmd and one in hadoop.cmd. Hadoop-config.cmd: for /f "delims=*" %%A in ("'%JAVA% -Xmx32m %HADOOP_JAVA_PLATFORM_OPTS% -classpath %CLASSPATH%"" org.apache.hadoop.util.PlatformName') do set JAVA_PLATFORM=%%A hadoop.cmd: call "%JAVA%" %JAVA_HEAP_MAX% %HADOOP_OPTS% -classpath %CLASSPATH% %CLASS% %hadoop-command-arguments% But I thought it more efficient to have it in a single place where everything following gets fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
