liuml07 commented on pull request #2248:
URL: https://github.com/apache/hadoop/pull/2248#issuecomment-681200251


   If it's a no-op instead of a potential bug, then the current code seems fine.
   
   As to which way is better, I think a second opinion will be useful here. 
@aajisaka 
   
   Or if it is not overkill, we apply two approaches together so existing code 
works and future code using this variable will also work most likely?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to