[ https://issues.apache.org/jira/browse/HADOOP-17229?focusedWorklogId=479960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479960 ]
ASF GitHub Bot logged work on HADOOP-17229: ------------------------------------------- Author: ASF GitHub Bot Created on: 08/Sep/20 09:14 Start Date: 08/Sep/20 09:14 Worklog Time Spent: 10m Work Description: steveloughran merged pull request #2264: URL: https://github.com/apache/hadoop/pull/2264 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 479960) Time Spent: 1h 50m (was: 1h 40m) > Test failure as failed request body counted in byte received metric - > ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics > ------------------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-17229 > URL: https://issues.apache.org/jira/browse/HADOOP-17229 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure, test > Affects Versions: 3.3.0 > Reporter: Sneha Vijayarajan > Assignee: Mehakmeet Singh > Priority: Major > Labels: abfsactive, pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Bytes received counter increments for every request response received. > [https://github.com/apache/hadoop/blob/d23cc9d85d887f01d72180bdf1af87dfdee15c5a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java#L251] > This increments even for failed requests. > Observed during testing done for HADOOP-17215. A request failed with 409 > Conflict contains response body as below: > {"error":\{"code":"PathAlreadyExists","message":"The specified path already > exists.\nRequestId:c3b2c55c-b01f-0061-7b31-7b6ee3000000\nTime:2020-08-25T22:44:07.2356054Z"}} > The error body of 168 size is incremented in bytes_received counter. > This also breaks the testcase testAbfsHttpResponseStatistics. > {code:java} > [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 22.746 s <<< FAILURE! - in > org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics[ERROR] Tests run: 2, > Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.746 s <<< FAILURE! - in > org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics[ERROR] > testAbfsHttpResponseStatistics(org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics) > Time elapsed: 13.183 s <<< FAILURE!java.lang.AssertionError: Mismatch in > bytes_received expected:<143> but was:<311> at > org.junit.Assert.fail(Assert.java:88) at > org.junit.Assert.failNotEquals(Assert.java:834) at > org.junit.Assert.assertEquals(Assert.java:645) at > org.apache.hadoop.fs.azurebfs.AbstractAbfsIntegrationTest.assertAbfsStatistics(AbstractAbfsIntegrationTest.java:445) > at > org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics(ITestAbfsNetworkStatistics.java:291) > {code} > [~mehakmeetSingh] - is the bytes_received counter increment for failed > requests an expected behaviour ? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org