[
https://issues.apache.org/jira/browse/HADOOP-17229?focusedWorklogId=480119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480119
]
ASF GitHub Bot logged work on HADOOP-17229:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/20 13:14
Start Date: 08/Sep/20 13:14
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2283:
URL: https://github.com/apache/hadoop/pull/2283#issuecomment-688857463
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 30m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 54s | branch-3.3 passed |
| +1 :green_heart: | compile | 0m 36s | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 0m 25s | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 0m 42s | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 19m 14s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 28s | branch-3.3 passed |
| +0 :ok: | spotbugs | 1m 6s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 3s | branch-3.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 36s | the patch passed |
| +1 :green_heart: | compile | 0m 31s | the patch passed |
| +1 :green_heart: | javac | 0m 31s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 19s | the patch passed |
| +1 :green_heart: | mvnsite | 0m 32s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | shadedclient | 18m 14s | patch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 23s | the patch passed |
| +1 :green_heart: | findbugs | 1m 3s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 24s | hadoop-azure in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate
ASF License warnings. |
| | | 113m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2283/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2283 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 123ec666bbb8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / 5710005 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~16.04-b01 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2283/1/testReport/ |
| Max. process+thread count | 422 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2283/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 480119)
Time Spent: 2h 40m (was: 2.5h)
> Test failure as failed request body counted in byte received metric -
> ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-17229
> URL: https://issues.apache.org/jira/browse/HADOOP-17229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure, test
> Affects Versions: 3.3.0
> Reporter: Sneha Vijayarajan
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: abfsactive, pull-request-available
> Fix For: 3.3.1
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Bytes received counter increments for every request response received.
> [https://github.com/apache/hadoop/blob/d23cc9d85d887f01d72180bdf1af87dfdee15c5a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java#L251]
> This increments even for failed requests.
> Observed during testing done for HADOOP-17215. A request failed with 409
> Conflict contains response body as below:
> {"error":\{"code":"PathAlreadyExists","message":"The specified path already
> exists.\nRequestId:c3b2c55c-b01f-0061-7b31-7b6ee3000000\nTime:2020-08-25T22:44:07.2356054Z"}}
> The error body of 168 size is incremented in bytes_received counter.
> This also breaks the testcase testAbfsHttpResponseStatistics.
> {code:java}
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 22.746 s <<< FAILURE! - in
> org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics[ERROR] Tests run: 2,
> Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.746 s <<< FAILURE! - in
> org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics[ERROR]
> testAbfsHttpResponseStatistics(org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics)
> Time elapsed: 13.183 s <<< FAILURE!java.lang.AssertionError: Mismatch in
> bytes_received expected:<143> but was:<311> at
> org.junit.Assert.fail(Assert.java:88) at
> org.junit.Assert.failNotEquals(Assert.java:834) at
> org.junit.Assert.assertEquals(Assert.java:645) at
> org.apache.hadoop.fs.azurebfs.AbstractAbfsIntegrationTest.assertAbfsStatistics(AbstractAbfsIntegrationTest.java:445)
> at
> org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics(ITestAbfsNetworkStatistics.java:291)
> {code}
> [~mehakmeetSingh] - is the bytes_received counter increment for failed
> requests an expected behaviour ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
