steveloughran commented on a change in pull request #2278: URL: https://github.com/apache/hadoop/pull/2278#discussion_r486262209
########## File path: hadoop-tools/hadoop-azure/src/test/resources/abfs-testrun-configs.xml.template ########## @@ -0,0 +1,156 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<configuration> + + <!--====================== IMPORTANT!! ========================--> + <!-- + 1. PLEASE PROVIDE VALUES FOR THE CONFIGS IN THIS FILE AND + RENAME THE SAME TO "abfs-testrun-configs.xml" + 2. UPDATE runtests.sh + A. "fs.azure.abfs.account.name" AND "fs.azure.test.namespace.enabled" + ARE MANDATORY WITH EVERY SCENARIO. AUTHTYPE BY DEFAULT WILL BE + SHAREDKEY AS CONFIGURED IN THIS TEMPLATE FILE. + B. PLEASE ADD MORE SCENARIOS IF THE CODE CHANGE REQUIRES TESTING WITH + DIFFERENT VARIANTS OF CONFIGS. + 3. THE SCRIPT REQUIRES THE FOLLOWING UTILITIES xmlstarlet AND pcregrep Review comment: OK. Is it documented where to get these from? homebrew on the mac finds xmlstarlet, but not pcgrep ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
