LeonGao91 commented on pull request #2288: URL: https://github.com/apache/hadoop/pull/2288#issuecomment-694612231
> Thanks @LeonGao91 for your works, some comment inline. > I wonder that if someone could config more than one archive path at one device (for some reason or mis-config), then it may not work correct, right? Which works fine for logic disk in my opinion although it is not recommended. Thanks. Thanks for the review! @Hexiaoqiao I think this feature is mostly useful if users don't want to setup Linux level partitions to divide DISK/ARCHIVE, in which the size of partitions is difficult to change in production. For the question: 1) It checks the underling filesystem mount to identify if two volumes are on the same mount, instead of the real physical disk. So it should work if the mount on a logical partition. The reason is datanode uses DF to calculate capacity-related information, which is on the filesystem mount level. This patch is making sure the capacity of DISK/ARCHIVE volume is correctly calculated and reported. 2) If users mistakenly configured multiple archive paths on the same mount, it will throw an error msg (as per [this line).](https://github.com/apache/hadoop/pull/2288/files#diff-8aa3c5049e8a5394bea1aa107dd87d30R339) But yes the capacity will not be reported correctly in this case. Please let me know what do you think, we can probably just exit DN and let users fix the config. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
