[
https://issues.apache.org/jira/browse/HADOOP-16830?focusedWorklogId=487278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487278
]
ASF GitHub Bot logged work on HADOOP-16830:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/20 21:28
Start Date: 21/Sep/20 21:28
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2323:
URL: https://github.com/apache/hadoop/pull/2323#issuecomment-696387784
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
10 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 45s | trunk passed |
| +1 :green_heart: | compile | 21m 32s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 19m 19s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 0m 59s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 45s | trunk passed |
| +1 :green_heart: | shadedclient | 20m 24s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 34s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 1m 38s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 2m 45s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 42s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 2s | the patch passed |
| -1 :x: | compile | 22m 3s | root in the patch failed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | javac | 22m 3s | root in the patch failed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | compile | 19m 42s | root in the patch failed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -1 :x: | javac | 19m 42s | root in the patch failed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -0 :warning: | checkstyle | 0m 53s |
hadoop-common-project/hadoop-common: The patch generated 17 new + 142 unchanged
- 4 fixed = 159 total (was 146) |
| +1 :green_heart: | mvnsite | 1m 31s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | shadedclient | 16m 50s | patch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 34s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | javadoc | 1m 40s |
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new
+ 1 unchanged - 0 fixed = 2 total (was 1) |
| -1 :x: | findbugs | 2m 50s | hadoop-common-project/hadoop-common
generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 5s | hadoop-common in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 55s | The patch does not generate
ASF License warnings. |
| | | 180m 35s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.counters; locked 60% of
time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 183] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.gauges; locked 60% of time
Unsynchronized access at IOStatisticsSnapshot.java:60% of time Unsynchronized
access at IOStatisticsSnapshot.java:[line 188] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.maximums; locked 60% of
time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 198] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.meanStatistics; locked 60%
of time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 203] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.minimums; locked 60% of
time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 117] |
| | org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject
method is synchronized At IOStatisticsSnapshot.java: At
IOStatisticsSnapshot.java:[lines 241-254] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.MeanStatistic.samples; locked 93% of time
Unsynchronized access at MeanStatistic.java:93% of time Unsynchronized access
at MeanStatistic.java:[line 261] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.MeanStatistic.sum; locked 91% of time
Unsynchronized access at MeanStatistic.java:91% of time Unsynchronized access
at MeanStatistic.java:[line 261] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2323 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle markdownlint |
| uname | Linux c43559ab4697 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c8c1cc43d35 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| compile |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| compile |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/testReport/ |
| Max. process+thread count | 2630 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/1/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 487278)
Time Spent: 2h (was: 1h 50m)
> Add public IOStatistics API
> ---------------------------
>
> Key: HADOOP-16830
> URL: https://issues.apache.org/jira/browse/HADOOP-16830
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs, fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Applications like to collect the statistics which specific operations take,
> by collecting exactly those operations done during the execution of FS API
> calls by their individual worker threads, and returning these to their job
> driver
> * S3A has a statistics API for some streams, but it's a non-standard one;
> Impala &c can't use it
> * FileSystem storage statistics are public, but as they aren't cross-thread,
> they don't aggregate properly
> Proposed
> # A new IOStatistics interface to serve up statistics
> # S3A to implement
> # other stores to follow
> # Pass-through from the usual wrapper classes (FS data input/output streams)
> It's hard to think about how best to offer an API for operation context
> stats, and how to actually implement.
> ThreadLocal isn't enough because the helper threads need to update on the
> thread local value of the instigator
> My Initial PoC doesn't address that issue, but it shows what I'm thinking of
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
