[
https://issues.apache.org/jira/browse/HADOOP-16830?focusedWorklogId=488411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488411
]
ASF GitHub Bot logged work on HADOOP-16830:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/20 17:08
Start Date: 22/Sep/20 17:08
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2323:
URL: https://github.com/apache/hadoop/pull/2323#issuecomment-696855219
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
10 new or modified test files. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 35s | trunk passed |
| +1 :green_heart: | compile | 21m 3s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 17m 53s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 0m 48s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 23s | trunk passed |
| +1 :green_heart: | shadedclient | 18m 32s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 30s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 1m 27s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 2m 17s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 14s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 51s | the patch passed |
| +1 :green_heart: | compile | 20m 12s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | javac | 20m 12s |
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 2054 unchanged
- 0 fixed = 2074 total (was 2054) |
| +1 :green_heart: | compile | 17m 44s | the patch passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| -1 :x: | javac | 17m 44s |
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 20 new + 1950 unchanged
- 0 fixed = 1970 total (was 1950) |
| -0 :warning: | checkstyle | 0m 48s |
hadoop-common-project/hadoop-common: The patch generated 20 new + 141 unchanged
- 4 fixed = 161 total (was 145) |
| +1 :green_heart: | mvnsite | 1m 24s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | shadedclient | 15m 52s | patch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 29s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | javadoc | 1m 27s |
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new
+ 1 unchanged - 0 fixed = 2 total (was 1) |
| -1 :x: | findbugs | 2m 24s | hadoop-common-project/hadoop-common
generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 15s | hadoop-common in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 47s | The patch does not generate
ASF License warnings. |
| | | 171m 3s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.counters; locked 80% of
time Unsynchronized access at IOStatisticsSnapshot.java:80% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 115] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.gauges; locked 80% of time
Unsynchronized access at IOStatisticsSnapshot.java:80% of time Unsynchronized
access at IOStatisticsSnapshot.java:[line 116] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.maximums; locked 80% of
time Unsynchronized access at IOStatisticsSnapshot.java:80% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 118] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.meanStatistics; locked 80%
of time Unsynchronized access at IOStatisticsSnapshot.java:80% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 119] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.minimums; locked 80% of
time Unsynchronized access at IOStatisticsSnapshot.java:80% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 117] |
| | org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject
method is synchronized At IOStatisticsSnapshot.java: At
IOStatisticsSnapshot.java:[lines 241-254] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2323 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle markdownlint |
| uname | Linux 0de6be7071fb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 6b5d9e2334b |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/testReport/ |
| Max. process+thread count | 3223 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2323/2/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 488411)
Time Spent: 3h 10m (was: 3h)
> Add public IOStatistics API
> ---------------------------
>
> Key: HADOOP-16830
> URL: https://issues.apache.org/jira/browse/HADOOP-16830
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs, fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Applications like to collect the statistics which specific operations take,
> by collecting exactly those operations done during the execution of FS API
> calls by their individual worker threads, and returning these to their job
> driver
> * S3A has a statistics API for some streams, but it's a non-standard one;
> Impala &c can't use it
> * FileSystem storage statistics are public, but as they aren't cross-thread,
> they don't aggregate properly
> Proposed
> # A new IOStatistics interface to serve up statistics
> # S3A to implement
> # other stores to follow
> # Pass-through from the usual wrapper classes (FS data input/output streams)
> It's hard to think about how best to offer an API for operation context
> stats, and how to actually implement.
> ThreadLocal isn't enough because the helper threads need to update on the
> thread local value of the instigator
> My Initial PoC doesn't address that issue, but it shows what I'm thinking of
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
