[
https://issues.apache.org/jira/browse/HADOOP-17271?focusedWorklogId=487671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487671
]
ASF GitHub Bot logged work on HADOOP-17271:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/20 03:26
Start Date: 22/Sep/20 03:26
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2324:
URL: https://github.com/apache/hadoop/pull/2324#issuecomment-696415310
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 3s | No case conflicting files
found. |
| +0 :ok: | markdownlint | 0m 2s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
39 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 3m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 42s | trunk passed |
| +1 :green_heart: | compile | 23m 33s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 20m 9s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 4m 5s | trunk passed |
| +1 :green_heart: | mvnsite | 4m 23s | trunk passed |
| +1 :green_heart: | shadedclient | 28m 49s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 2m 4s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 3m 12s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 1m 42s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 7m 14s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 55s | the patch passed |
| +1 :green_heart: | compile | 30m 51s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javac | 30m 51s |
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 0 new + 2058 unchanged -
1 fixed = 2058 total (was 2059) |
| +1 :green_heart: | compile | 25m 33s | the patch passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | javac | 25m 33s |
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 0 new + 1952 unchanged -
1 fixed = 1952 total (was 1953) |
| -0 :warning: | checkstyle | 3m 46s | root: The patch generated 25 new
+ 267 unchanged - 25 fixed = 292 total (was 292) |
| +1 :green_heart: | mvnsite | 4m 3s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | shadedclient | 19m 17s | patch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 59s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | javadoc | 1m 58s |
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new
+ 1 unchanged - 0 fixed = 2 total (was 1) |
| +1 :green_heart: | javadoc | 0m 38s | hadoop-mapreduce-client-core in
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
|
| +1 :green_heart: | javadoc | 0m 47s |
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 0 new +
0 unchanged - 4 fixed = 0 total (was 4) |
| -1 :x: | findbugs | 3m 46s | hadoop-common-project/hadoop-common
generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 42s | hadoop-common in the patch passed.
|
| +1 :green_heart: | unit | 7m 23s | hadoop-mapreduce-client-core in
the patch passed. |
| +1 :green_heart: | unit | 1m 48s | hadoop-aws in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate
ASF License warnings. |
| | | 245m 34s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.counters; locked 60% of
time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 183] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.gauges; locked 60% of time
Unsynchronized access at IOStatisticsSnapshot.java:60% of time Unsynchronized
access at IOStatisticsSnapshot.java:[line 188] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.maximums; locked 60% of
time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 198] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.meanStatistics; locked 60%
of time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 203] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.IOStatisticsSnapshot.minimums; locked 60% of
time Unsynchronized access at IOStatisticsSnapshot.java:60% of time
Unsynchronized access at IOStatisticsSnapshot.java:[line 117] |
| | org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject
method is synchronized At IOStatisticsSnapshot.java: At
IOStatisticsSnapshot.java:[lines 241-254] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.MeanStatistic.samples; locked 93% of time
Unsynchronized access at MeanStatistic.java:93% of time Unsynchronized access
at MeanStatistic.java:[line 261] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.MeanStatistic.sum; locked 91% of time
Unsynchronized access at MeanStatistic.java:91% of time Unsynchronized access
at MeanStatistic.java:[line 261] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2324/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2324 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle markdownlint xml |
| uname | Linux 28c82d916bcc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c8c1cc43d35 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2324/1/artifact/out/diff-checkstyle-root.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2324/1/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2324/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2324/1/testReport/ |
| Max. process+thread count | 2904 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-tools/hadoop-aws U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2324/1/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 487671)
Time Spent: 50m (was: 40m)
> S3A statistics to support IOStatistics
> --------------------------------------
>
> Key: HADOOP-17271
> URL: https://issues.apache.org/jira/browse/HADOOP-17271
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> S3A to rework statistics with
> * API + Implementation split of the interfaces used by subcomponents when
> reporting stats
> * S3A Instrumentation to implement all the interfaces
> * streams, etc to all implement IOStatisticsSources and serve to callers
> * Add some tracking of durations of remote requests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
