[
https://issues.apache.org/jira/browse/HADOOP-17271?focusedWorklogId=490747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-490747
]
ASF GitHub Bot logged work on HADOOP-17271:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/20 13:08
Start Date: 25/Sep/20 13:08
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2324:
URL: https://github.com/apache/hadoop/pull/2324#issuecomment-698305241
```
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:41:
* @deprecated use {@link
org.apache.hadoop.util.functional.FunctionRaisingIOE}: Line is longer than 80
characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:54:
* @deprecated use {@link
org.apache.hadoop.util.functional.BiFunctionRaisingIOE}: Line is longer than 80
characters (found 83). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FunctionsRaisingIOE.java:65:
* @deprecated use {@link
org.apache.hadoop.util.functional.CallableRaisingIOE}: Line is longer than 80
characters (found 81). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/package-info.java:28:
* {@link org.apache.hadoop.fs.statistics.IOStatisticsSource#getIOStatistics()}
.: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:1723:
});: 'block rcurly' has incorrect indentation level 6, expected level
should be one of the following: 8, 10. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:1740:
});: 'block rcurly' has incorrect indentation level 6, expected level
should be one of the following: 8, 10. [Indentation]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/files/PendingSet.java:222:
public void setIOStatistics(final IOStatisticsSnapshot ioStatistics) {:58:
'ioStatistics' hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/files/SinglePendingCommit.java:450:
public void setIOStatistics(final IOStatisticsSnapshot ioStatistics) {:58:
'ioStatistics' hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/files/SuccessData.java:352:
public void setIOStatistics(final IOStatisticsSnapshot ioStatistics) {:58:
'ioStatistics' hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/NetworkBinding.java:57:
* If {@code SSLConnectionSocketFactory} cannot be found on the classpath,
the value: Line is longer than 80 characters (found 86). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/StoreContextBuilder.java:116:
final S3AStatisticsContext statisticsContext) {:34: 'statisticsContext'
hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/statistics/CommitterStatistics.java:21:import
org.apache.hadoop.fs.statistics.IOStatisticsSource;:8: Unused import -
org.apache.hadoop.fs.statistics.IOStatisticsSource. [UnusedImports]
```
I'm going to update with those fixes, and then actually move to a leaner
version of this PR
* no rework of stats context/interfaces
* just make S3AInstrumentation classes all serve up IOStatistics, with
common base classes
This will massively reduce the s3a code diff, and meets the core goal of
"easier for apps to pick up statistics of application use".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 490747)
Time Spent: 2.5h (was: 2h 20m)
> S3A statistics to support IOStatistics
> --------------------------------------
>
> Key: HADOOP-17271
> URL: https://issues.apache.org/jira/browse/HADOOP-17271
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> S3A to rework statistics with
> * API + Implementation split of the interfaces used by subcomponents when
> reporting stats
> * S3A Instrumentation to implement all the interfaces
> * streams, etc to all implement IOStatisticsSources and serve to callers
> * Add some tracking of durations of remote requests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
