[
https://issues.apache.org/jira/browse/HADOOP-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116937#comment-13116937
]
Aaron T. Myers commented on HADOOP-7695:
----------------------------------------
bq. Are you ok with the same patch? (or) Expecting some change?
No, the same patch won't work. Note that the {{else}} clause where the log
message is printed could be reached if the {{proxy}} or {{invocationHandler}}
objects are {{null}}, so it's not safe to call {{.getClass()}} on the objects,
as is done in your patch.
If you feel strongly, I don't mind reassigning this issue to you.
> RPC.stopProxy can throw unintended exception while logging error
> ----------------------------------------------------------------
>
> Key: HADOOP-7695
> URL: https://issues.apache.org/jira/browse/HADOOP-7695
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.24.0
>
>
> {{RPC.stopProxy}} includes the following lines in case of error:
> {code}
> LOG.error("Could not get invocation handler " + invocationHandler +
> " for proxy " + proxy + ", or invocation handler is not
> closeable.");
> {code}
> Trouble is, the {{proxy}} object is usually backed by {{WritableRpcEngine}},
> which will fail in the event {{toString}} is called on one of its proxy
> objects. See HADOOP-7694 for more details on that issue. Until that's
> addressed, we might as well change the log message in {{RPC.stopProxy}} to
> not call {{toString()}} on {{proxy}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
