[
https://issues.apache.org/jira/browse/HADOOP-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116995#comment-13116995
]
Hadoop QA commented on HADOOP-7695:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12496958/HADOOP-7695.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/244//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/244//console
This message is automatically generated.
> RPC.stopProxy can throw unintended exception while logging error
> ----------------------------------------------------------------
>
> Key: HADOOP-7695
> URL: https://issues.apache.org/jira/browse/HADOOP-7695
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.24.0
>
> Attachments: HADOOP-7695.patch
>
>
> {{RPC.stopProxy}} includes the following lines in case of error:
> {code}
> LOG.error("Could not get invocation handler " + invocationHandler +
> " for proxy " + proxy + ", or invocation handler is not
> closeable.");
> {code}
> Trouble is, the {{proxy}} object is usually backed by {{WritableRpcEngine}},
> which will fail in the event {{toString}} is called on one of its proxy
> objects. See HADOOP-7694 for more details on that issue. Until that's
> addressed, we might as well change the log message in {{RPC.stopProxy}} to
> not call {{toString()}} on {{proxy}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
