viirya commented on a change in pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#discussion_r497068326
##########
File path: hadoop-common-project/hadoop-common/src/main/native/native.vcxproj
##########
@@ -68,30 +68,13 @@
<IntDir>..\..\..\target\native\$(Configuration)\</IntDir>
<TargetName>hadoop</TargetName>
</PropertyGroup>
- <PropertyGroup>
- <SnappyLib
Condition="Exists('$(CustomSnappyPrefix)\snappy.dll')">$(CustomSnappyPrefix)</SnappyLib>
- <SnappyLib Condition="Exists('$(CustomSnappyPrefix)\lib\snappy.dll') And
'$(SnappyLib)' == ''">$(CustomSnappyPrefix)\lib</SnappyLib>
- <SnappyLib Condition="Exists('$(CustomSnappyPrefix)\bin\snappy.dll') And
'$(SnappyLib)' == ''">$(CustomSnappyPrefix)\bin</SnappyLib>
- <SnappyLib Condition="Exists('$(CustomSnappyLib)') And '$(SnappyLib)' ==
''">$(CustomSnappyLib)</SnappyLib>
- <SnappyInclude
Condition="Exists('$(CustomSnappyPrefix)\snappy.h')">$(CustomSnappyPrefix)</SnappyInclude>
- <SnappyInclude Condition="Exists('$(CustomSnappyPrefix)\include\snappy.h')
And '$(SnappyInclude)' == ''">$(CustomSnappyPrefix)\include</SnappyInclude>
- <SnappyInclude Condition="Exists('$(CustomSnappyInclude)') And
'$(SnappyInclude)' == ''">$(CustomSnappyInclude)</SnappyInclude>
- <SnappyEnabled Condition="'$(SnappyLib)' != '' And '$(SnappyInclude)' !=
''">true</SnappyEnabled>
- <IncludePath Condition="'$(SnappyEnabled)' ==
'true'">$(SnappyInclude);$(IncludePath)</IncludePath>
- <IncludePath
Condition="Exists('$(ZLIB_HOME)')">$(ZLIB_HOME);$(IncludePath)</IncludePath>
Review comment:
I think it is together with snappy stuffs here, no? They are in same
`PropertyGroup`. I think it is used to add zlib home into include paths in the
property group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
