viirya commented on a change in pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#discussion_r497099812
##########
File path: hadoop-project-dist/pom.xml
##########
@@ -341,7 +340,6 @@
<argument>--openssllib=${openssl.lib}</argument>
<argument>--opensslbinbundle=${bundle.openssl.in.bin}</argument>
<argument>--openssllibbundle=${bundle.openssl}</argument>
-
<argument>--snappybinbundle=${bundle.snappy.in.bin}</argument>
<argument>--snappylib=${snappy.lib}</argument>
<argument>--snappylibbundle=${bundle.snappy}</argument>
Review comment:
Re-checked. hadoop-mapreduce-client-nativetask doesn't use
`bundle.snappy.in.bin`. Only native-win profile of hadoop-common and native-win
profile in hadoop-project use `bundle.snappy.in.bin`. They are added by
HADOOP-9802 to support SnappyCodec on Windows. So looks like it is safe to
remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
