[
https://issues.apache.org/jira/browse/HADOOP-17295?focusedWorklogId=496583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496583
]
ASF GitHub Bot logged work on HADOOP-17295:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 13:01
Start Date: 07/Oct/20 13:01
Worklog Time Spent: 10m
Work Description: coder-chenzhi commented on a change in pull request
#2358:
URL: https://github.com/apache/hadoop/pull/2358#discussion_r500992285
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java
##########
@@ -566,11 +566,10 @@ public void writeLocalWrapperScript(Path launchDst, Path
pidFile,
@Override
public boolean signalContainer(ContainerSignalContext ctx)
throws IOException {
- String user = ctx.getUser();
String pid = ctx.getPid();
Signal signal = ctx.getSignal();
LOG.debug("Sending signal {} to pid {} as user {}",
Review comment:
Sorry for my mistake. I did not notice that developer has changed this
logging call to parameterized logging and removed the logging guard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496583)
Time Spent: 40m (was: 0.5h)
> Move dedicated pre-logging statements into existing logging guards
> ------------------------------------------------------------------
>
> Key: HADOOP-17295
> URL: https://issues.apache.org/jira/browse/HADOOP-17295
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chen Zhi
> Assignee: Chen Zhi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I find some cases where some pre-processing statements dedicated to logging
> calls are not guarded by existing logging guards. Most of them are easy to
> fix. And the performance and maintainability of these logging calls can be
> improved to some extend. So I create a PR to fix them.
> These issues are detected by a static analysis tool wrote by myself. This
> tool can extract all the dedicated statements for each debug-logging calls
> (i.e., the results of these statements are only used by debug-logging calls).
> Because I realize that debug logs will incur overhead in production, such as
> string concatenation and method calls in the parameters of logging calls as
> well as pre-processing statements. And I want to perform a systematic
> evaluation for the overhead of debugging logging calls in production.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
