[
https://issues.apache.org/jira/browse/HADOOP-17295?focusedWorklogId=496604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496604
]
ASF GitHub Bot logged work on HADOOP-17295:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 13:32
Start Date: 07/Oct/20 13:32
Worklog Time Spent: 10m
Work Description: coder-chenzhi commented on pull request #2358:
URL: https://github.com/apache/hadoop/pull/2358#issuecomment-704938615
@steveloughran Appreciate your review. Your comment on the logging overhead
is valuable for me.
I have another question that I would like to hear your thoughts. Do you
prefer to reduce accumulated overhead or average overhead? The point is that
some simple logging calls are on the hot path and frequently executed. The
accumulated overhead for these simple logging calls is larger than other
complex logging calls rarely executed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496604)
Time Spent: 1h (was: 50m)
> Move dedicated pre-logging statements into existing logging guards
> ------------------------------------------------------------------
>
> Key: HADOOP-17295
> URL: https://issues.apache.org/jira/browse/HADOOP-17295
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chen Zhi
> Assignee: Chen Zhi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I find some cases where some pre-processing statements dedicated to logging
> calls are not guarded by existing logging guards. Most of them are easy to
> fix. And the performance and maintainability of these logging calls can be
> improved to some extend. So I create a PR to fix them.
> These issues are detected by a static analysis tool wrote by myself. This
> tool can extract all the dedicated statements for each debug-logging calls
> (i.e., the results of these statements are only used by debug-logging calls).
> Because I realize that debug logs will incur overhead in production, such as
> string concatenation and method calls in the parameters of logging calls as
> well as pre-processing statements. And I want to perform a systematic
> evaluation for the overhead of debugging logging calls in production.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
