vinaysbadami commented on a change in pull request #2464:
URL: https://github.com/apache/hadoop/pull/2464#discussion_r523917070
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -92,6 +99,9 @@ public AbfsInputStream(
this.cachedSasToken = new CachedSASToken(
abfsInputStreamContext.getSasTokenRenewPeriodForStreamsInSeconds());
this.streamStatistics = abfsInputStreamContext.getStreamStatistics();
+ this.readSmallFilesCompletely = abfsInputStreamContext
+ .readSmallFilesCompletely();
Review comment:
we are passed in an AbfsInputStreamContext. We should hold onto that
instance instead of creating member variables for each of the members of
AbfsInputStreamContext.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
