bilaharith commented on a change in pull request #2464:
URL: https://github.com/apache/hadoop/pull/2464#discussion_r526582998
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -128,7 +138,7 @@ public synchronized int read(final byte[] b, final int off,
final int len) throw
}
incrementReadOps();
do {
- lastReadBytes = readOneBlock(b, currentOff, currentLen);
+ lastReadBytes = readToUserBuffer(b, currentOff, currentLen);
Review comment:
I have forked 3 different methods from the existing ethod readOneBlock,
readFileCompletely. readLastBlock and readOneBlock. There are common parts from
the existing method readOneBlock is used from for all the 3 forked methods. In
that case renaming the existing method to readToUserBuffer would make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
