[ 
https://issues.apache.org/jira/browse/HADOOP-16881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243357#comment-17243357
 ] 

Wei-Chiu Chuang commented on HADOOP-16881:
------------------------------------------

Thanks for the patch, LGTM +1

Note to myself:
the connection leak inside the delegation token authenticator doesn't look that 
critical, compared to the Kerberos authenticator, because the leak will only 
happen for getDelegationToken(), renewDelegationToken(), cancelDelegationToken. 

Unrelated to the patch itself, someone should review the ATS code to understand 
why the connection is not reused. Without using delegation tokens, a typical 
workflow is the kerberos authenticator acquires credentials, and then another 
connection to send requests. That subsequent request connection should be 
reused.

> PseudoAuthenticator does not disconnect HttpURLConnection leading to 
> CLOSE_WAIT cnxns
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-16881
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16881
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: auth, security
>    Affects Versions: 3.3.0
>            Reporter: Prabhu Joseph
>            Assignee: Attila Magyar
>            Priority: Major
>         Attachments: HADOOP-16881.1.patch
>
>
> PseudoAuthenticator and KerberosAuthentication does not disconnect 
> HttpURLConnection leading to lot of CLOSE_WAIT connections. YARN-8414 issue 
> is observed due to this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to