amahussein opened a new pull request #2554:
URL: https://github.com/apache/hadoop/pull/2554


   While investigating 
[YARN-10334](https://issues.apache.org/jira/browse/YARN-10334) I found that in 
   `applications.distributedshell.Client` , the method `monitorApplication` 
loops waiting for the following conditions:
   
   * Application fails: reaches `YarnApplicationState.KILLED`, or 
`YarnApplicationState.FAILED`
   * Application succeeds: `FinalApplicationStatus.SUCCEEDED` or 
`YarnApplicationState.FINISHED`
   * the time spent waiting is longer than `clientTimeout` (if it exists in the 
parameters).
   
   When the Client thread is interrupted, it ignores the exception:
   
   ```java
         // Check app status every 1 second.
         try {
           Thread.sleep(1000);
         } catch (InterruptedException e) {
           LOG.debug("Thread sleep in monitoring loop interrupted");
         }
   ```
   
   Also, the timeout will be measured against the object creation timestamp 
which is incorrect.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to