amahussein commented on a change in pull request #2554:
URL: https://github.com/apache/hadoop/pull/2554#discussion_r545314569
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
##########
@@ -1139,34 +1147,38 @@ private boolean monitorApplication(ApplicationId appId)
FinalApplicationStatus dsStatus = report.getFinalApplicationStatus();
if (YarnApplicationState.FINISHED == state) {
if (FinalApplicationStatus.SUCCEEDED == dsStatus) {
- LOG.info("Application has completed successfully. Breaking
monitoring loop");
- return true;
- }
- else {
- LOG.info("Application did finished unsuccessfully."
- + " YarnState=" + state.toString() + ", DSFinalStatus=" +
dsStatus.toString()
- + ". Breaking monitoring loop");
- return false;
+ LOG.info("Application has completed successfully. "
+ + "Breaking monitoring loop");
+ res = true;
+ } else {
+ LOG.info("Application did finished unsuccessfully. "
+ + "YarnState={}, DSFinalStatus={}. Breaking monitoring loop",
+ state.toString(), dsStatus.toString());
}
- }
- else if (YarnApplicationState.KILLED == state
+ break;
+ } else if (YarnApplicationState.KILLED == state
|| YarnApplicationState.FAILED == state) {
- LOG.info("Application did not finish."
- + " YarnState=" + state.toString() + ", DSFinalStatus=" +
dsStatus.toString()
- + ". Breaking monitoring loop");
- return false;
+ LOG.info("Application did not finish. YarnState={}, DSFinalStatus={}. "
+ + "Breaking monitoring loop",
+ state.toString(), dsStatus.toString());
Review comment:
Thanks @goiri ! I added a commit to get rid of the "toString()".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
