amahussein commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756132738
> Thank for working on this, @amahussein. LGTM overall pending some nits. > > While it is too late here, it is hard to follow which part of the TestDistributedShell is modified if splitting the class and refactoring are mixed up in a single commit. Doing one thing in one PR makes reviewing and cherry-picking easier. That's good point @iwasakims . Sorry that I made it hard. After my first commit, I received feedback from Inigio to transform busy-waiting loops into lambda. It is my bad I haven't managed to separate between refactoring and splitting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
